Grisha Kruglov

Results 25 comments of Grisha Kruglov

Setting at least the `PRAGMA temp_store = 2` was my suggestion as well, as a starting point for this 👍

API we landed in A-C - https://github.com/mozilla-mobile/android-components/pull/11058

Wow, interesting. We definitely don't have safeguards against this in the metadata storage queries. I also wonder if there's some bug upstream of the queries, e.g. it's hard to imagine...

We're seeing a ton of this in Sentry - https://sentry.prod.mozaws.net/operations/firefox/issues/9616768/events/0420a9b6ab3b4a6b8ef0615245d5e73e/ - would be great to have a recovery path. Also, I'm assuming it's been verified that we aren't doing anything...

From [a-s](https://github.com/mozilla/application-services/blob/673e700194cfa44ad3c8629f74a2b01844cea7c3/components/logins/android/src/main/java/mozilla/appservices/logins/LoginsStorageException.kt#L45): ``` * This error is emitted in two cases: * * 1. An incorrect key is used to to open the login database * 2. The file at...

Similarly on iOS: https://github.com/Azure/communication-ui-library-ios/pull/303 and Android: https://github.com/Azure/communication-ui-library-android/pull/382 We'll find a publicly accessible "shared home" for this info to live in, and replace this doc w/ a link; for now just...

Happy to see that there are now perf metrics for the awesomebar (https://github.com/mozilla-mobile/firefox-ios/pull/11601), although that doesn't seem to explicitly cover autocompletion cases (but perhaps frecent history + bookmarks is used...

There was some recent churn around TimeConstants and SQLiteHistory, but it seems harmless? https://github.com/mozilla-mobile/firefox-ios/commit/3012efa1c26a05b238f348d5f2354e02e322bd59#diff-81fb7197aeaf972e86ac0b4c1be58360b1de77a1b37a1b0d565a031a77a3a64cL256 - although I did spend too much time looking at the changes to convince myself that...