griff і⊙

Results 49 comments of griff і⊙

Related to https://github.com/cashapp/sqldelight/issues/5086 and https://github.com/AlecKazakova/sql-psi/pull/616 Looking into how this can be added in PostgreSql Dialect

Currently, this is limited by the implementation of `JoinClauseMixin` in sql-psi project https://github.com/AlecKazakova/sql-psi/blob/6ea26b938a617c74e0b12c782dae9e9a8cc62537/core/src/main/kotlin/com/alecstrong/sql/psi/core/psi/mixins/JoinClauseMixin.kt#L65 The base SQL implementation only supports resolving columns with `LEFT` joins as not all databases e.g `MySql`...

🤔 I will try and create a PR to test out a fix 🛠️ There are at-least three ways that could be implemented to set the parameter and type in...

🕊️ From the description it could be this existing issue/bug - where `INSERT INTO ...VALUES(...) RETURNING id;` statements don't create an `emit` table notification for use in Flow https://github.com/cashapp/sqldelight/issues/3743 https://github.com/cashapp/sqldelight/discussions/4618

Closing this for now as it does work on current 2.0.1 😖 There is even a test fixture in `sql-psi` test-fixtures/build/resources/main/fixtures/well-formed-selects I will re-open and update if issue reappears with...

Seems to be similar to other issue caused by nested square brackets https://github.com/AlecKazakova/sql-psi/pull/554 🙅 Have tried fix in sql-psi but not quite working fully https://github.com/AlecKazakova/sql-psi/blob/4d6f68a981b82daeecbd157c1f36af4223782a0a/core/src/main/kotlin/com/alecstrong/sql/psi/core/sql.bnf#L368

🤔 This could be fixed by https://github.com/cashapp/sqldelight/pull/4885 issue https://github.com/cashapp/sqldelight/issues/4448 - It just missed the 2.0.1 release Maybe try the snapshot release `2.1.0-SNAPSHOT` and see if that works for you To...

🕊️ Sadly, I am not familiar with this issue. Though on quick inspection 🔍 the problem looks to be in [SqlDelightQueriesFile](https://github.com/cashapp/sqldelight/blob/a61f04c6eb6066c2b7a07f686b59c23f5bd65a1e/sqldelight-compiler/src/main/kotlin/app/cash/sqldelight/core/lang/SqlDelightQueriesFile.kt#L65) I can have a look and see if there...

Yes - indeed Currently, that I have tried myself, only a [grouping](https://cashapp.github.io/sqldelight/2.0.0/android_sqlite/grouping_statements/) used with a [flow](https://cashapp.github.io/sqldelight/2.0.0/android_sqlite/coroutines/) like this will work. Any fix, would also have to work for `INSERT INTO...