cashapp
Inserts not emitted to listeners when using grouping statement
SQLDelight Version
2.0.0-alpha02
Operating System
Android
Gradle Version
7.5
Kotlin Version
1.7.20
Dialect
default
AGP Version
No response
Describe the Bug
Stacktrace
No response
Gradle Build Script
No response
I am hitting the same issue when using SQLite 3.35 RETURNING statement in an insert e.g.
INSERT INTO ... VALUES(...) RETURNING _id;
this is intentional, the alternative to whats there right now is returning an observable query which means it will execute the update/insert whenever the underlying table changes. I assume you only want to observe the SELECT or returned type, so you need to make a separate query for the reactive query
Hi @griffio 9 months passed and nothing is done? Why it's allowed to insert or upsert into a table if the changes are not notified to listeners?
🕊️ Sadly, I am not familiar with this issue. Though on quick inspection 🔍 the problem looks to be in SqlDelightQueriesFile
I can have a look and see if there is a fix - I would have to try a few things but can't promise 🎀
🤔 Looks like only when there is a SELECT statement in the group does it not emit the notification.
This means that calling notifyQueries only makes sense when used after transaction statements that don't return a QueryResult from a transactionWithResult(). For example - if you look at the generated source code and try manually adding the notifyQueries, where would it go?
Thank you for your answer. I know that if the query returns any data it won't notify listeners. But it's a bug. It means "If you want to use a query with returning clause don't use flows".
Yes - indeed
Currently, that I have tried myself, only a grouping used with a flow like this will work.
Any fix, would also have to work for INSERT INTO ...VALUES(...)RETURNING _id; - we can't generate "nested" transactions for a single statement - maybe it's possible to generate something like...
transactionWithResult {
driver.execute(...)
...
driver.executeQuery(...)
}.also {
notifyQueries(...) { emit ->
emit("subscription")
}
}
Maybe create a 📣 discussion question so other contributors can see it better ? https://github.com/cashapp/sqldelight/discussions
I created a PR, #5006 that should fix it.
I notice now that I also came up with the same idea @griffio brought (using also). Let's see how it goes :)
