Robert Griesemer comments

Results 88 comments of


                                            Robert Griesemer

cmd/compile: inconsistent typechecking with self-referential type parameter constraints

Too late for 1.23. Moving to 1.24.

cmd/compile: stack overflow when typechecking self-referential types

Definitely a bug. The optimization in validtype.go (exit early for *Named types) is incorrect (caches break things).

go/types, types2: error reported for valid shifts

Didn't get to this. Moving to 1.20.

go/types, types2: error reported for valid shifts

Pushing ahead again.

go/types, types2: error reported for valid shifts

Moving once more.

go/types, types2: error reported for valid shifts

This has been open for some time w/o causing major issues - though it should be fixed. Removing "early in cycle" label for now.

go/types, types2: error reported for valid shifts

Didn't get to this. Moving to 1.24.

go/types, types2: improve API for setting type parameter constraints in importers

@findleyr Anything to be done here at this point? Let's decide and then do or close.

go/types, types2: improve API for setting type parameter constraints in importers

Bumping to 1.24 unless you want to close this, @findleyr .

go/internal/gcimporter: fix suppressed gotypesalias=1 tests

The first error, related to $goroot/test/typeparam/issue50259.go, may possibly be an incorrect type declaration (TBD). The 2nd and 3rd error, related to $goroot/test/typeparam/struct.go, disappears once the compiler is switched to using...