Gavin Ridley

Results 115 comments of Gavin Ridley
trafficstars

We should be good for another review here, now! I removed the exception crap to just use `mark_as_lost` and `fatal_error` instead. However, we need to use a virtual here in...

Oh sweet! OK I just realized that the `mark_as_lost` does actually have to be virtual to get the right behavior, and I have to move the `id_` data to `Geometron`,...

Alright, *now* it should be good for review!

Just sharing this nice image I made for the docs. Imagine how many voxels you'd need to create this previously! ![phong_triso](https://github.com/openmc-dev/openmc/assets/18088906/202bd66d-ee24-4509-8ee8-b410ea52d3ae)

@cfichtlscherer has some super nice stuff too. Are you able to give any sneak peeks Chris?

`test_evaluate_legendre` is failing for me in CI. No way it's related to the recent commits... Any ideas?

OK @pshriwise, just resolved any conflicts, could you give this one more review?

OK, pretty sure I got all your comments addressed @pshriwise!

This automatic clang format is driving me nuts. I am running clang format, but they're different versions and have some tiny whitespace differences. I've dropped some pretty unnecessary comments in...

Why should this be added to OpenMC? IMO it is a little too specific and unrelated to particle transport. There are a variety of ways to solve this particular problem,...