Gavin Ridley
Gavin Ridley
@pshriwise do you still consider this to be a draft?
Very nice. But as for implementation, it looks like this may duplicate the other rejection code introduced in #2235. In fact there is no reason this should strictly pertain to...
Hey Erik, yes, I think if it doesn't specifically pertain to sources from a file this should be in the base class. The capability added here seems to pertain to...
Interesting observation about kill vs. resample! Hm, I guess we really should have either one be possible, so I'll wait for someone else to weigh in on that. I will...
Yes I completely agree on that, although the kill on reject feature would indeed be helpful!
Hey Paul! OK, yes, that makes sense now. I agree that it'd be a bummer to not take advantage of some efficiency considerations in rejection in favor of the most...
Yikes, I agree! This hearkens back to your comment a while ago about slots. For instance if you put `mylat.lower_letf` this same error would pop up, and that can be...
Awesome! I'm pretty sure all that would be needed would be multiplying the macroscopic cross sections calculated in `Material::calculate_neutron_xs` after the loop over individual nuclides takes place. There may be...
Why not just have people use `int(1e6)`?
Nice! I always wondered why we couldn't do this. Pre-packing a binary for windows could be very nice for some users.