Stephen Sherratt
Stephen Sherratt
Hey thanks for the detailed suggestions. I want to share a bit of context from inside the build system team. Previously we had a long-lived branch that includes the toolchains...
Also to clarify, implementing this feature correctly is something I want to do eventually but if there's a way to quickly upstream something that solves the problem now I'd like...
Thanks for the feedback everyone. Closing this in favour of a new PR that re-implements this functionality based on the feedback. https://github.com/ocaml/dune/pull/10719.
I've added a bunch of https://github.com/ocaml/dune/pull/11833 into this PR. Once https://github.com/ocaml/dune/pull/11833 is merged this diff will get much smaller.
Will do. I was waiting for https://github.com/ocaml/dune/pull/11879 to be merged first as it changes a lot of code in exec.ml.
@Leonidas-from-XIV all the prereqs for this are now merged. Can you please take a look.
> Very useful work, however I am concerned about the maintainability if the tests are disabled for being flaky. Is there maybe some way to make them more stable? Flaky...
Here's an example session using this command: ``` 37 s@u3 ~/src/llama (main=) + λ dune exec --which ocamlbuild _build/_private/default/.pkg/ocamlbuild/target/bin/ocamlbuild 38 s@u3 ~/src/llama (main=) + λ dune exec --which ocamlc /home/s/.cache/dune/toolchains/ocaml-compiler.5.3.0-a3dd2a36d935a7ada272441c8543eba1/target/bin/ocamlc...
It is, yes, but I bet a lot of people don't know you can expand pforms like that (for example I did not know this).
Updated this so that the command is now `dune which `.