Stephen Sherratt

Results 193 comments of Stephen Sherratt

Hi @A-RAKSHITHA. Since this issue is quite large, I'm asking interns to first post a proposal for solving a subset of the problem first (see my comment above to @kemsguy7,...

Thanks @kemsguy7, I've created https://github.com/ocaml/dune/issues/11575. It's just for the first part of the first part of your proposal (print a warning on `(= version)`). Looks like I can't assign you...

@A-RAKSHITHA are you still interested in contributing to this? If so please suggest a conservative subset of this problem you'd like to work on that doesn't overlap with https://github.com/ocaml/dune/issues/11575.

Hey @A-RAKSHITHA, > I’d like to work on detecting common typos in top-level field names of the dune-project file—such as verion instead of version, or autors instead of authors This...

Thanks for the patch, I'll take a look next week.

I added a few more doc comments to the `Toolchain` module and revised some of the existing comments. I also renamed `Compiler.uninit` to `Compiler.t` and renamed `Compiler.t` to `Compiler.installed` as...

Thanks for the review @rgrinberg!

> Looking over the integration with Pkg_rules again, I pointed out a few flaws I didn't notice earlier. I know you've dismissed this earlier, but I can't help but think...

@rgrinberg I've started experimenting with a more conservative implementation of toolchains based on your suggestion. The only difference is in pkg_rules, where the toolchain is installed as if it was...