Oliver Powell

Results 15 comments of Oliver Powell

@C-Otto I'm assuming you'd want all types of temporary channel failures to be logged in this way? Eg. "outgoing htlc is too large" as well? Also I'm assuming you'd still...

refresh-paths option would be amazing!

Seems like supporting these kind of error groups is a newish feature, see: https://github.com/getsentry/sentry/issues/37716

Also the RFC: https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md

Here's the [sentry-javascript implementation](https://github.com/getsentry/sentry-javascript/pull/8463/files), so this change will be a bit more involved.

This is definitely more in the spirit of Go, but we also need to respect the [unified API](https://develop.sentry.dev/sdk/unified-api/) for consistency across the various language SDKs. Perhaps we could add a...

I guess this can be solved in #111 which is still open and on the backlog

@lawrencejones This only seems to happen specifically when calling a closured function correct? Or at least I can't see this behaviour otherwise. Could you share a deep sentry stack trace...

I think adding the `instrumenter` option also seems to be consistent with the other sdks.

LGTM, but I'll let @cleptric give the final thumbs up :)