Gregory Igelmund

Improve user feedback if defining static association with a block

6

### Problem this feature will solve Given: ```rb FactoryBot.define do user(factory: :author) { association(:author, role: role) } end ```` [`DefinitionProxy#method_missing`](https://github.com/thoughtbot/factory_bot/blob/907139808d728dbe8da59856afe068b7c0699b2a/lib/factory_bot/definition_proxy.rb#L91-L104) will declare the [association](https://github.com/thoughtbot/factory_bot/blob/master/lib/factory_bot/definition_proxy.rb#L97) and ignore any given `block`-argument. ###...

Addresses #1503 ## Why Providing an options `factory`-key with an assocation definition effectively ignores a given block. Users might be confused by this behaviour, so we might want to raise...

Addresses path collisions on case-insensitive file systems

1

Replacement for #1581 ## Why are the changes necessary? See issue description at https://github.com/thoughtbot/factory_bot/issues/1580 ## What changes are proposed? The 2 conflicting file paths are: - `docs/src/summary.md`: An intro describing...

Path collisions `docs/src/{SUMMARY,summary}.md`

1

### Description When cloning the current repository on a case-insensitive file system git warns about path collisions: ``` git clone https://github.com/thoughtbot/factory_bot.git tmp … warning: the following paths have collided (e.g....

Replacement for the prematurely closed PR #1518 Why: ---- When defining an association the block-argument will be ignored when also providing a `factory`-key on the association definition. This behaviour might...

Support for `Element::add_attribute`

2

I'm using the [ruby](https://github.com/gjtorikian/selma) binding for `lol_html` and would really like to be able to transform `Foo` into `Foo`. I understand that the `lol_html` API currently implements [Element.html#set_attribute](https://docs.rs/lol_html/1.2.0/lol_html/html_content/struct.Element.html#method.set_attribute) with a...

Note: Add body & author

19

## Why are the changes necessary? Addresses #3831 which describes how a set of bugs related to the current `Note`-model can be solved by merging the "special first comment" into...