Greg Wilkins
Greg Wilkins
@lorban hmmm I've broken a few tests.... more than I would have expected..... Anyway, I'm tools down for the day. The branch is yours to play with... or to look...
> I discussed the latest state with @sbordet and he raised two points: > > * We need to add a serie of new `Callback.from` helpers that take 3 parameters,...
> > Oh, and I finally figured `onAbort`, `onCompleteSuccess`, `onCompleteFailure` and `completed`, and I like them. Now I just think `completed` should be renamed to `onCompleted`, and the javadocs should...
Hmmm, I think I have found a use-case for having just a onFailure(Throwable) which is called immediately on abort or failure, in addition to onCompleteFailure.... I'm working on that now...
> > Hmmm, I think I have found a use-case for having just a onFailure(Throwable) which is called immediately on abort or failure, in addition to onCompleteFailure.... I'm working on...
> Friendly reminder that these changes may impact [Spring's Jetty Core support](https://github.com/spring-projects/spring-framework/pull/32097). How can they affect Spring? At worst, abort(x) is not implemented in a callback, so turns into a...
@sbordet @lorban I've updated for much of your feedback. Specifically simplifying the signature of Callback.Abstract and also fixing the onAbort race that it had. There are now numerous test failures,...
@sbordet @lorban I think we have an issue with extensions of ICB that override `succeeded()`. Typically these overrides are releasing buffers and/or chunks, but now that we have a serialized...
@sbordet I'm also now a bit cautious about the change you asked for, where it is `onCompleted(Throwable)` that calls `onCompleteSuccess()` or `onCompleteFailure(Throwable)`. That means that overrides of `onCompleted` should call...
@lorban @sbordet I very much doubt this is going to be ready in time for 12.0.11. I think we should consider merging early in the 12.0.12 cycle or even only...