Greg Wilkins

Results 470 comments of Greg Wilkins

@lachlan-roberts @sbordet @lorban ^

> The problem is that `HttpContent` is in `jetty-http` so any possible signature would be to only depend on `jetty-http` ... This is not an issue. This design is only...

> I'm still not convinced about this. Yeah well, the convincing needs to go both ways! I'm not convinced about the currently checked in code and I only acquiesced to...

> @gregw If my understanding is correct, you're proposing to manage static content with a mechanism vaguely similar to the the 11.0.x handler one: pass the request/response/callback trio to some...

> @gregw it is currently not true that HC has access to request and response because it lives in `jetty-http` and not in `jetty-server`. At best it has access to...

> @gregw I thought you wanted `HttpContent implements Request.Processor`? > No. read all my comments above where I proposed: ```java interface HttpContentProcessor extends Request.Processor { HttpContent getHttpContent(); } ``` This...

See also discussion at https://github.com/eclipse/jetty.project/pull/8767#discussion_r1016457778

@lachlan-roberts @sbordet @joakime @lorban I'm just re pitching the need for an async API in resources in this comment. It is a distillation of what I think after all the...

@lachlan-roberts can you link your branch here. Was there ever a PR that actually got reviewed? I think we need to capture the discussions around this.

> @gregw the branch is here https://github.com/eclipse/jetty.project/tree/jetty-12.0.x-AsyncHttpContent > > It never had a PR but we reviewed in hangout with @sbordet and @lorban and decided that it introduced too much...