Greg Wilkins

Results 470 comments of Greg Wilkins

@meltsufin I'm not going to have a chance to run this myself for a few hours. But I'm guessing the problem is that this compat runs with the working directory...

@meltsufin perhaps we need a PR on google-cloud-logging that will print any exceptions to stderr so we one can better debug logging problems in init?

That update explains a bit. For a request to /contextPath there are two actions that take place: 1. a redirection is performed to /contextPath/, so that relative paths will work...

@ludoch How is the context path being set in this case? It is hard coded to / in root.xml in the images I can see?

I've been testing 9.3.x and it does correctly map requests to /context to welcome files even if setAllowNullPathInfo(true) has been called. It may be JSP related, but we need to...

@ludoch still need to checkout how he is setting context path before we deploy anything By "a standard GAE all" do you mean master or something prior to that? Will...

The request log is setup in jetty9 by [gae.xml](https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/blob/async-support/jetty9-base/src/main/jetty-base/etc/gae.xml#L42-L52) and in jetty9-compat by a similar [gae.xml](https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/blob/async-support/jetty9-compat-base/src/main/jetty-base/etc/gae.xml#L54-L64) This indicates we are rolling the logs daily and that we keep the logs...

@joakime also it would be good to filter out the routine health check requests

@joakime The GAE deployment unit is the war file, so any configuration uploaded for deployment is in the war file. So it's not necessarily punching a hole in the classloader,...

The fact that we don't generate the hidden classes list has bitten us in this case. We needed to have added `org.slf4j.` and `org.apache.log4j` to the server class. But we...