Greg Wilkins

Results 470 comments of Greg Wilkins

> We throw for "must not happen" kind of situations. > > Returning an error chunk is more like a failure that may happen (e.g. early EOF). > > I...

> * Clear out uncertainty: there's only one way to be notified of errors, so you don't have to wear a belt (`isError()`) & suspenders (`try / catch`). and if...

@sbordet all very good points I think. More thoughts inline > * The default for `maxBucketSize` is `Integer.MAX_VALUE` which means that it always create a `CompoundPool` with possibly a large...

The other thought that comes to mind is that we should again validate our assumption that pooling buffers is worthwhile. If we really need a complex buffer pool with eviction,...

What version of spring are you using? This could be an issue in the spring jetty 12 integration, which is new code and less tested than jetty 12 itself.

@lorban could we include spring boot integration in our performance testing?

@joakime most of the jetty spring boot integration is actually in spring-framework and the 12 code is all rather new

I'm 99% sure that `server.compression.enabled=true` in springboot enables the underlying servers compression mechanism. i.e. our GzipHandler and not some spring compression service. So this looks like we may have an...

I have a draft of this, but it is waiting for #9035 to be merged

#9056 has improved the implementation and merged the multiple handlers into a single one. However, the API for extending it is not satisfactory and more thought is needed, so this...