Greg Wilkins

Results 470 comments of Greg Wilkins

I don't understand the concept of an annotated priority? Surely implementor will just set it to Integer.MAX_VALUE to encourage usage of their implementation! On Wed, 28 Apr 2021, 06:08 Romain...

I've looked a little bit more at this and I think we need to never emit a content chunk that ends with a CR, as that may be the first...

I think I have convinced myself this is correct.... but I also think it needs either some better comments, and/or perhaps some simplifications. I'll have a fiddle this afternoon and...

@joakime @sbordet I have pushed to this branch some simplifications to the logic and some comments that make it easier for me to understand. If you think they are at...

@sbordet if it is just the fall throughs that you don't like, then let me put the if elses back, as I think there were some good simplifications even without...

@sbordet interesting! So it is worthwhile spending some time looping to find a bucket that can be evicted so that the just released buffer can be pooled. I wonder how...

@sbordet I think we are really close now... and probably over-analysing beyond the fidelity of JMH.... but we are here now, so let's finish... Your JMH test is OK, but...

@sbordet my changes are in https://github.com/jetty/jetty.project/tree/fix/jetty-12/11371/review-abbp-eviction3 I can push to your branch if you like?

> The moment we use a `Writer` for HTTP, or we use WebSocket, the range of buffers used will depend entirely on the application writes, which may be clustered around...

A halfway step could be to make all our existing setters return this, so that they can be used in fluent style: ```java Server server = new Server(); server. .addConnector(new...