Greg Dennis

Results 1181 comments of Greg Dennis

Furthermore, we need to be cognizant of this text that follows as well: > Although ISO 8601 permits the hour to be "24", this profile of ISO 8601 only allows...

I'm not sure about that. I think while a feature is experimental, it should stay separate. It should only be merged into the main suite when incorporated into the spec...

@karenetheridge there are two phases to proposal acceptance where you might implement a feature. The first is what you're talking about where just a few of us check viability. The...

I think I prefer option 2. _Allow_ `#*` but discourage it. Maybe include its support as a MAY requirement to let implementations decide.

I'm happy with removing it. I think having the strings match makes sense, and it removes all "URI" association. I can easily add the option in my lib.

I think it's fine as is. > The value of this keyword MUST be a string. Implementations MUST NOT present this string to end users. Tools for editing schemas SHOULD...

I pretty much leave it up to .Net's built-in [`Uri`](https://learn.microsoft.com/en-us/dotnet/api/system.uri) type, though I haven't done any testing to see if it actually works. I think 2 and 3 make the...

> Passes punycode decode/encode roundtrip After updating my library, I've found that it has a really hard time with punycode, specifically. I've opted not to support these for now.

In order to move forward with @jdesrosiers' suggestion, we'll need to put the [format registry](https://github.com/json-schema-org/json-schema-spec/issues/1552) in place first.

Hey @jochenkirstaetter. Thanks for the report. I see your PR. Please refresh yourself on our [contributing guidelines](https://github.com/json-everything/json-everything/blob/master/CONTRIBUTING.md).