Greg Maya
Greg Maya
Wow.! Ok definitely PRs are a science in itself! .. Thanks for the explanations... although some still sound foreign to me I'll have your recommendations to start Googling. Many thanks...
sorry I marked the PR as 'ready for review' by mistake! (not sure how to undo 😅)
Hoping the auto-BLACK pre-commit action is actually working. 🧐
> @gregmaya give us a shout if you want another round of reviews. A review would be appreciated, yes! @martinfleis I really want to move to a selection algorithm (which...
@martinfleis I have updated the code to incorporate a lot of what we discussed yesterday: - I went through the code and made sure I avoided pandas warnings (when possible...
@martinfleis I've combined all the suggestions by @jGaboardi as well as included a `diameter_factor` for including adjacent polygons that stretch a bit more than what was considered before. I cannot...
> 3.8-minimal has old geopandas. That needs to be catched and we should raise an error saying that the function requires newer version than 0.x.0 (need to check which is...
Hey Martin. Thanks for reaching out. I was thinking I would better come back to this before the ideas escape my mind. I've been rather busy trying to find payed...
@martinfleis I feel very sorry that I've not been able to contribute more to this. As a matter of fact, my coding skills have probably suffered some rustiness as I've...
Hi @martinfleis and @jGaboardi. I do feel very sorry that I have not been able to keep up with this as we all would've liked. Lately, I've tried to spend...