Gergely Kalapos

Results 49 issues of Gergely Kalapos

More details on the original problem: https://github.com/elastic/apm-agent-dotnet/pull/560#issuecomment-543239630 Turned out that we had some files with windows style line ending (`CRLF`) and some with linux/macOS style ending (`LF`). My theory is...

technical debt

Follow up from https://github.com/elastic/apm-agent-dotnet/pull/1702#pullrequestreview-976588383. Current situation: - Tests with `AzureCredentialsFact` run on Linux - Those don't run on Windows - The skip reason on Windows is: `Azure credentials not available....

agent-dotnet

Reported [via discuss](https://discuss.elastic.co/t/elastic-apm-extensions-hosting-doesnt-work-with-net48-if-you-already-have-a-dependency-on-microsoft-extensions-dependencyinjection-version-5-0/289403) - see more details there. ``` System.MissingMethodException: Method not found: 'Microsoft.Extensions.Hosting.IHostingEnvironment Microsoft.Extensions.Hosting.HostBuilderContext.get_HostingEnvironment()'. at Elastic.Apm.Extensions.Hosting.HostBuilderExtensions.c__DisplayClass0_1.b__1(IServiceProvider sp) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite...

bug
good first issue
agent-dotnet

We should offer users the ability to manually send metrics. I think there would be 2 approaches: - Integrate with an existing metrics library (e.g. [AppMetrics](https://github.com/AppMetrics/AppMetrics), [Metrics.NET](https://github.com/etishor/Metrics.NET)) - Extend the...

enhancement

Since this would be a fairly big major change: This is not a final decision, we may not do it! Even if we do this, it'll be only in a...

breaking change
agent-dotnet

Currently we do [this](https://github.com/elastic/apm-agent-dotnet/blob/master/src/Elastic.Apm.AspNetCore/ApmMiddleware.cs#L99) as the default transaction name. Usually the transaction name will end up being something created by [this logic](https://github.com/elastic/apm-agent-dotnet/blob/master/src/Elastic.Apm.AspNetCore/ApmMiddleware.cs#L286) using the MVC controller/action name or the razor...

[Docs](https://www.elastic.co/guide/en/apm/agent/dotnet/current/config-http.html#config-capture-body-content-types) already indicate that this is dynamic, but does not show up for .NET now. From https://github.com/elastic/apm-agent-dotnet/issues/1144

agent-dotnet

https://github.com/elastic/apm-server/issues/1523 For .NET this could be useful to differentiate sync and async calls.

enhancement
cross APM agents

From https://github.com/elastic/apm-agent-dotnet/issues/1039 With version `1.7.0` the agent has higher CPU usage. Seems to be caused by GC - and increased allocation seems to be caused by `EnhancedStackFrame`. Plan: let's see...

agent-dotnet

With the `Elastic.Apm.Extensions.Hosting` package we support `IHostBuilder` based agent setup. We also introduced `AspNetCoreDiagnosticListener` which does the same as the middleware does, but it works based on DiagnosticSource. Reason for...

breaking change