apm-agent-dotnet icon indicating copy to clipboard operation
apm-agent-dotnet copied to clipboard

Remove default `{context.Request.Method} {context.Request.Path}` transaction name in ASP.NET Core

Open gregkalapos opened this issue 3 years ago • 1 comments

Currently we do this as the default transaction name. Usually the transaction name will end up being something created by this logic using the MVC controller/action name or the razor page name.

But if that logic fails (mainly because we don't have that info) we keep the transaction name with the path in it.

But according to the spec

The transaction name should be aggregatable, such as the route or handler name.

And the path should not show up in the transaction name.

So let's default to <METHOD> unknown route as the spec defines.

gregkalapos avatar Aug 17 '20 15:08 gregkalapos

@gregkalapos is this something we still want to do? From a cursory look, it looks like updating

https://github.com/elastic/apm-agent-dotnet/blob/cc11d34f945425261f2ac50cc90fb6b44b55a441/src/Elastic.Apm.AspNetCore/WebRequestTransactionCreator.cs#L37

is the only change (plus tests)?

russcam avatar Nov 09 '21 04:11 russcam