Greggman

Results 352 comments of Greggman

I'm just thinking out loud without looking at the code. `random() * 1000 % max` will never make value greater than 1000 so if you're picking from 1000000 random things...

I tested with one of the folders trees I really intended to use. It has 2370 entries. * readdir 55 seconds * chokidar 22 mins, 26 seconds. That means the...

It seems kind of sad to me you closed this ticket. Isn't this an issue people should be aware of they can look for solutions? Checking on Mac to the...

You claimed the issue is chokidar is CPU intensive. Watching the CPU on my test above I see no evidence of this. It never goes above 3%

The code in question is exactly as pasted above. (the typo was only in my last message not in any code I've been running) On Mac it's exactly as pasted...

I tried walk-filtered and it took 3-4 seconds in the same setup. I have a feeling I'm just going to run into all the problems previous adventurers have run into...

Sorry just starting to get back into this. What I did notice today is chokidar has issues on Windows even not on shares. I tried to run this small sample...

vscode still uses chokidar. You can see it in the package.json, Here's the top level code for their watcher This code https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/files/node/fileService.ts#L198 used vscode-nsfw based on a flag, otherwise it...

That is the entire point of the issue. That chokidar is 24x slower on a network drive than other techniques. Not sure why you closed it. Seems like 24x slower...

The watchers are here https://github.com/microsoft/vscode/tree/master/src/vs/platform/files/node/watcher On Windows it uses a C# app which it runs in a separate process and looks at its output https://github.com/microsoft/vscode/tree/master/src/vs/platform/files/node/watcher/win32