Greg Anderson

Results 388 comments of Greg Anderson

I agree that we should not stub out nodejs / ruby component installation in our base template projects. I don't know that we need an `echo` in `build-assets`, as long...

Correct, Lukas is working on this. We can leave this issue open for tracking.

I'm not sure about the deprecation notice; that was fixed in the past. Maybe it's coming from Composer 1? We are aware of the Composer 2 limitation. A fix is...

This PR uses Lightning v2, which is based on packagist.drupal.org, just as drupal-composer/drupal-project is. Includes a couple of simple passing tests, including an installer test.

Looks very useful. Maybe reduce duplication by combining `case test` with `case dev` (maybe even make it the default, so that it applies to multidevs) & use a variable for...

I think @ataylorme 's new scheme would actually be pretty inconvenient _unless_ you map every multidev environment to `dev`: ``` $env_name = isset($plugins_to_activate_and_deactivate[ $_ENV['PANTHEON_ENVIRONMENT'] ]) ? $_ENV['PANTHEON_ENVIRONMENT'] : 'dev'; ```...

I'm not sure that you can manually bootstrap from a Quicksilver script. Try using `exec` or `passthru` with the `drush` that is in the current PATH, and run `drush php-script`...

Yes, I was only addressing the `create_cloud_development_environment` scenario. I think it might be difficult or impossible to enable solr every time a site is spun up from an upstream (e.g....

[passthru](https://www.php.net/manual/en/function.passthru.php) takes an optional second parameter to capture the status result code (0-255). The Terminus Build Tools plugin defines a convenience wrapper for passthru: ``` /** * Call passthru; throw...

I think that a good example: - Is clear - Is correct - Has no dependencies (works standalone) I therefore think that duplicating a short passthru utility in every example...