Greg Anderson
Greg Anderson
I think that rather than complicating things too much, we should simply: - Create a multidev called `pr-PULL_REQUEST_NUMBER` when there is a PR available. - Create a multidev called `ci-CIRCLE_BUILD_NUMBER`...
I felt that the number of distinct steps in the circle 2.0 tests were adding complexity that was not needed. In the drops-8 example, I simplified to just two: -...
We do need to run the `build_deploy_and_test` step for the master branch, and any feature branch that is being used like master (e.g. a `1.x` branch, et. al.). In the...
The `ci-` multidevs should not have naming conflicts, as they are named after the Circle build number. You could get naming conflicts if you use one Pantheon site to test...
As @ataylorme [mentions in another issue](https://github.com/pantheon-systems/example-wordpress-composer/issues/28), there is a potential problem with using the Circle build number to name the multidev used for the site-under-test, as every build step gets...
There is also a workflow ID: ``` CIRCLE_WORKFLOW_ID=b935e0b1-6ca9-4577-82ad-77016922c8d4 ``` The problem here is obvious: the ID itself is far too long to use in a multidev name, and if we...
I made a support request asking for exactly that information (but in an environment variable). Text from my support request: > > In Circle 1.x, we would name external resources...
Circle support pointed me at an [existing Circle CI discussion](https://discuss.circleci.com/t/2-0-need-circle-workflow-id-env-var-exposed/14200/11) about this feature request. Those who want this feature should LIKE comments in that discussion, as Circle CI apparently evaluates...
I didn't actually recommend removing `build-assets` in the referenced issue; I suggested we might need something other than a composer script to build assets, and I suggested that perhaps the...
Presently, I think that a composer script is the right way to handle this. I am seeing other people in the PHP / Composer community move in this direction. For...