George P

Results 6 comments of George P

Hello @stokito, as mentioned in #332, would you consider an extra parameter, to clearly specify the minimum number of masked characters? From your implementation I can see that it is...

Hello @stokito > As I understood you are telling about more safety and do not unmask any symbol if incoming string is too short while implementation which I proposed will...

> it will not always obviously which minMasked to use. I am sorry, but I didn't understand this, can you please further elaborate? ``minMasked`` will be one, and it will...

> Just to clarify: maskedStart from this PR corresponds to minMasked from #332 but the discussion is about adding a maxUnmasked, right? I don't see a ``maskedStart`` parameters, these are...

Hello @stokito, thanks for the input. The reasoning of creating two method was for a more intuitive API and to not add too many parameters in just one method. And...

New method added, to cover usacases of https://issues.apache.org/jira/browse/LANG-1400