greatroar

Results 82 comments of greatroar

Just a hunch, but does the problem go away if you change [fs.fixpath](https://github.com/restic/restic/blob/c542a509f08a92fe499932d826c5af07d3977525/internal/fs/file_unix.go#L14) to return filepath.Abs(name)?

Seems like a sound design overall. Does need a changelog entry, though.

The reasoning was to use something that nobody puts in their tags, so that as few tags as possible get mangled. Your suggestion is probably more reasonable, though. The remaining...

@fd0 TagsDir.Lookup also needs to compute the inverse transformation, and your suggestion is not invertible: "foo__bar" could have been "foo_bar" or "foo//bar". Maybe we need to approach this differently and...

@rawtaz I can imagine people backing up web data and using URLs as tags...

The title says rclone backup, but you clearly mean restic backup.

The consensus among maintainers (expressed at #3061) is to wait until Go 1.16, which will include a thorough fix in the stdlib. If that's right, may I suggest adding a...

In my experience, when transient errors are possible, you wrap the Reader to deal with them rather than encumbering every consumer with the problem. How would LZ4 know which errors...

On second thought, maybe I was wrong and it would be better to pass received errors through and not remember them, so the caller can handle them by retrying. Also,...