greatroar
greatroar
I was just about to post the interface suggestion. Putting everything in the event package means having to update two packages every time something changes in the log formatting.
Yes, I was just trying my hand at that (except I used a custom Verbose method). It's a lot of repetitive work, but it looks like Failure, ItemStarted and ItemFinished...
> Defining some events in a central registry and others where they are produced seems confusing. It is kind of weird, but some types need to be known in multiple...
moment.js is already checked in. It has a pretty nifty method to format and localize durations, if loss of precision is acceptable: ``` > moment.locale('it'); > moment.duration(10, 'seconds').humanize(); 'alcuni secondi'...
Reverting the commit causes a regression. I've sent a better fix to lz4.
That package has init functions that need to run: https://github.com/gogo/protobuf/blob/226206f39bd7276e88ec684ea0028c18ec2c91ae/gogoproto/gogo.pb.go#L708-L787
Yes, it would be better if this were configurable (with 15 the minimum). Note that scrypt uses (1
I was off by a factor of two: it's 1GiB, not 2GiB, for N=20.
Given that glob patterns are essentially regular expressions on path names, would it be feasible to translate the exclude file to a regexp, compile that and use it to match...
Update on the regexp idea: I was wrong, matching against regular expressions still takes O(mn) in the worst case because a regexp matcher needs to maintain O(m) state, where m...