Andy Allan

Results 143 comments of Andy Allan

> I'm going to continue using cucumber as that's how I get from the design document Design.md to test scenarios, to specs, to code. I'm not opposed to minitest. In...

@openbrian Let me know when you would like a review. I can see a few things that we should discuss, but I think you're still iterating on things. My preference...

Does anyone have any feedback on this PR, or #3030? Useful, not useful, good approach, etc?

> I was just giving this `rake dev:populate` a try. It works! Great, thanks for testing it out! Glad to hear that it worked. > If so, then I guess...

![image](https://user-images.githubusercontent.com/360803/98821588-a970d280-2427-11eb-95f1-ac9b165e33a1.png)

> We're not going to start installing node from upstream just for this! Perhaps not. But I think we'll need to address the issue of Node versions at some point...

I think we can probably change the validation to only trigger when the description changes during the update - i.e. allow the description to remain blank, but not to allow...

> Why do you need description to be non-blank if everything works when it's blank? I can't really answer that, since I wasn't involved in making them required originally (nor...

I'm happy with the proposed tab from a UX perspective. But from a technical PoV, I don't know enough about how the javascript stuff works to review it confidently.