David comments

Results 5 comments of


                                            David

Some commands seem to be decoded incorrectly (get "Message was shorter than expected.")

Yeah, I tried to [force query all commands](https://github.com/graus/pihatsu/blob/9b8c57d90eb09a4afc60be23015877e78a6ff67d/force-run-cmds.py#L9), and each command yields the same message/padding issue; ``` Jan 14 16:51:13 pihatsu rc.local[274]: [obd.obd] ======================= python-OBD (v0.7.0) ======================= Jan 14 16:51:13...

Some commands seem to be decoded incorrectly (get "Message was shorter than expected.")

OK, I've added some prints to the OBDCommand.py Below are some of the responses/messages I receive. Not sure if this is as expected? - I don't know what the `A`s...

Some commands seem to be decoded incorrectly (get "Message was shorter than expected.")

OK! I managed to fix it, I figured I'd try to not prune the last (checksum?) byte, i.e., I turned [obd/protocols/protocol_legacy.py#L76](https://github.com/brendan-w/python-OBD/blob/a372044ebbfd48cd2f998b46d96ae3d92363786a/obd/protocols/protocol_legacy.py#L76) into: ``` frame.data = raw_bytes[3:] ``` And now I...

Some commands seem to be decoded incorrectly (get "Message was shorter than expected.")

I wouldn't mind submitting a PR, but I'm not sure whether it is a general thing or something specific with my setup/hardware: I've seen multiple sources mention the last byte...

Some commands seem to be decoded incorrectly (get "Message was shorter than expected.")

I have no clue, where could I find documentation? The auto-detected protocol is `ISO_14230_4_5baud`, and w.r.t.: "Are you sure that the output produced after your modification is correct?" Pretty sure,...