Marco Granelli
Marco Granelli
Seems like the wasm keys in storage do not fall under any address and therefore have no associated VP. https://github.com/anoma/namada/blob/7d70e5a7a4ef50bdad2df9f665ffa39998c328c5/crates/core/src/storage.rs#L698-L732 Since we prevent modification to non-protected keys in storage, this...
The functions that verifies the masp signatures and proofs currently lives in the SDK crate. We don't really have a plan to expose this to external developers, so we should...
## Describe your changes Closes #2592. Modifies the protocol logic to charge the gas consumed by the fee unshielding operation, which therefore will pay fees. The gas is charged to...
## Describe your changes Closes #2594. Call `valid_nullifiers_reveal` regardless of the transaction source to make sure that a shielding tx doesn't reveal any nullifier. Enforces that at least one shielded...
The masp client has some intrinsics limitations when it comes to producing transactions which derives from previous txs' output descriptions for which it has not queried a node. More specifically,...
## Describe your changes Closes #2922. Since there's no more need to keep track and possibly act on tx cases from different block, this PR removes the `ReProtStorageModification` enum and...
https://github.com/anoma/namada/blob/621cce94399e3ce5088e07dfff842f438b216103/crates/apps/src/lib/node/ledger/shell/governance.rs#L122 Here it looks like we read the proposal code from storage even though we know that the transaction doesn’t have on. Also, we ignore the actual result of the...
https://github.com/anoma/namada/blob/621cce94399e3ce5088e07dfff842f438b216103/crates/apps/src/lib/node/ledger/shell/governance.rs#L367-L387 Here we match the result of executing the proposals but it looks like we don’t drop the state in the case the execution was not accepted meaning that the...
After #2601, governance proposals are allowed to change the asset map of masp for the conversions. At the moment though, the masp vp rejects these changes. We need to update...
After merging #2627 the transactions are now executed in order without the need to split the wrappers from the wasm transactions which poses an issue when it comes to fee...