Results 36 comments of Marco Granelli

> @yuji does this need a hermes update for `run_ledger_ibc_with_hermes`? @brentstone not this pr but the one on which it's based, see here https://github.com/anoma/namada/pull/3142#issuecomment-2086584442

Should this batch of multiple wasms be atomic or should we allow arbitrary txs to fail while still committing the successful ones? Given that the main (but not only) use...

Note: the integration tests are actually passing for me locally, they fail here because of a time limit on the CI step

> Do you know why the unit and integration tests are failing in the CI? They seem to be timing out for some reason... Do they pass on your machine?...

> Nice. Could you please just check out the `serialize_to_vec` issue in the comments to see if there is anything to it? And if you get the chance (but it's...

We should also set the maximum block height on the `Transaction` object (ideally the same as the embedding `Transfer` even though this is not trivial since the tx expiration is...

With regards to the fees, the logic in the code should be correct as we decided to not allow fee payment directly in a masp transfer, the check is here:...

@ameya-deshmukh yes sure, just make sure to set me as a reviewer for the PR, thank you!

Hi @emccorson, yes it's always possible to manually set a specific gas limit. The CLI argument is optional and this issue refers to the case where the user does not...

@murisi I actually think this has already been solved and can be closed