namada icon indicating copy to clipboard operation
namada copied to clipboard

Remove delta map

Open grarco opened this issue 9 months ago • 3 comments

Describe your changes

Extends #3142 by removing the unused delta_map. Also refactors/removes functions dealing with the balance keys.

Indicate on which release or other PRs this topic is based on

#3142 rebased on the tip ob base (diff for review: https://github.com/anoma/namada/pull/3172/files/2a25031ec579b802a0af75cff1ccbd08c8905c88..0ae083b7c347f2de353bc8b0dc1ee31baa1b3be6)

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

grarco avatar May 03 '24 14:05 grarco

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 59.76%. Comparing base (9d4de02) to head (0ae083b). Report is 12 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 34 Missing :warning:
crates/core/src/masp.rs 0.00% 5 Missing :warning:
crates/apps/src/lib/bench_utils.rs 0.00% 1 Missing :warning:
crates/ibc/src/actions.rs 0.00% 1 Missing :warning:
crates/namada/src/ledger/native_vp/ibc/context.rs 0.00% 1 Missing :warning:
crates/shielded_token/src/storage_key.rs 0.00% 1 Missing :warning:
crates/tx_prelude/src/ibc.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3172      +/-   ##
==========================================
+ Coverage   59.40%   59.76%   +0.36%     
==========================================
  Files         298      298              
  Lines       92326    91769     -557     
==========================================
  Hits        54849    54849              
+ Misses      37477    36920     -557     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 15:05 codecov[bot]

@yuji does this need a hermes update for run_ledger_ibc_with_hermes?

brentstone avatar May 07 '24 04:05 brentstone

@yuji does this need a hermes update for run_ledger_ibc_with_hermes?

@brentstone not this pr but the one on which it's based, see here https://github.com/anoma/namada/pull/3142#issuecomment-2086584442

grarco avatar May 07 '24 09:05 grarco