Grantland Chew
Grantland Chew
This is much cleaner! The new API method names seem a bit odd to me. Instead of `#isHeightFitting()`, `#setHeightFitting(boolean)`, etc. do you think `#isAutofitWidthEnabled()`, `setAutofitHeightEnabled(boolean)` sounds more natural? Additionally, this...
Does this occur with `AutofitTextView` or a regular `TextView` with `AutofitHelper`?
Hrmmm this seems like fixing this would be a breaking change for existing users... If someone is willing to submit a PR that namespaces the attrs, something like `autofit_` prefix,...
This sounds like a great idea, however, I'm not too familiar with enabling this functionality. Would you be willing to submit a PR for this or point to some reference...
Could someone confirm that this works on android-8? I would think it would crash when trying to load the class `View.OnLayoutChangeListener`. In addition, this needs to be rebased on `master`.
Unfortunately it looks like this change will only allow usage of `AutofitTextView` in android-8, but not `AutofitHelper` with other `TextView` implementations (i.e. `EditText`, etc.). Is this what you all would...
It looks like the class `AutofitTextView` is missing in your classpath, which leads me to believe you have an error in your project configuration.
It's probably a bad proguard configuration, but I don't know since this is out of the scope of this project.
This would be an awesome feature to add, however, it is very difficult to review as the entire files are shown as changed. Any chance you can update this with...
Use `android:maxLines="2"` instead of `android:singleLine="true"`.