Xavier Grangier

Results 21 comments of Xavier Grangier

Nested field support is also needed for video sitemaps. .... so the solution https://github.com/iamvishnusankar/next-sitemap/pull/220 does't seem to work

Actually you can disable image fetching if not needed. I do agree that I would be better not to download the whole image file if it's not needed. However, image...

@atlithorn could you source you piece of code ... it seems to be a Zope code right ?

Hello, I don't see why we need to change the Goose.**init** constructor, nor why we need to pass the http client around if the variable is not used. xav

@psilva261 the mocking testing stuff is now implemented. Did you check it out ?

What was the timeforkids.com issue ? I don't remember.

@psilva261 Hum weird. In my case the correct image is not extracted. It is still the author's image. ``` python >>> import goose >>> url = 'http://www.timeforkids.com/news/gaga-goo-goo-clusters/54591' >>> g =...

Problem is with this article the main image is not in the article top node. The only image in the article top_node is the author's image

@psilva261 i guess you don't have the same html on both side.

To solve this issue, the only way it to grab all the images of the document and not only the ones on the detected top_node. Side effects would be that...