gavin.wang

Results 8 comments of gavin.wang

> This is actually not the right way to do such things, we can't hardcode a hive conf in the MR code. > > The correct way would be to...

fix checkstyle of WhitespaceAfter,another one :'method call' child has incorrect indentation level 10 ,is legacy code

Why always "Docker failed to build" ?

Fix blanks eol,while the checkstyle error is keeping with the legacy code,the legacy code checkstyle fixed pr:https://github.com/apache/hadoop/pull/6958

@Hexiaoqiao @ayushtkn Thanks  for reviewing,I have updated the code

> Minor comments, rest LGTM > > side node: As of now If I am reading the code right, we can not specify data units while specifying the -blockSize as...

> there are checkstyle warnings here @ayushtkn Thanks for reviewing,I fixed 1 checkstyle warning:line length is too long. Another checkStyle warning,blockSize is protected which is from legacy code,and keeping with...