grandizzy

retired in favor of #7914

hey @pcaversaccio wanted to let you know that this change breaks `sneakmate` invariant `invariantExecutingNotReadyProposal` because time is now preserved between calls Let's say there's a first run calling `invariantExecutingNotReadyProposal` https://github.com/pcaversaccio/snekmate/blob/e20185c1776256984d888d02dc243fe793119f2e/test/governance/TimelockController.t.sol#L4352-L4368...

> @grandizzy thanks for the heads-up; what's the time plan on the release on this breaking change? @pcaversaccio I am checking with other projects how this affects their usage, so...

ping @PaulRBerg @lucas-manuel do you forsee any issue (like the one above) in your projects? Thank you

btw, if you want to give it a quick check you can set `preserve_state = true` as this will be made default with this PR

tested ok ajna, morpho, maple, basin, llama, dss-conduit, weth-invariant-testing listed at https://github.com/perimetersec/public-fuzzing-campaigns-list?tab=readme-ov-file#foundry-invariant-testing

> This is great! > > > (for example if the persisted sequence fails in 100 steps but config was altered to run with a depth of 50 then persisted...

> LGTM > > I think there can be potential issues with `fail_on_revert` set to true. If user changes setUp routines, then persisted sequence might become invalid because contract addresses...

> Not sure how we can address that, perhaps display some kind of warning when persisted sequence is reverting rather than failing an invariant? @klkvr please check https://github.com/foundry-rs/foundry/pull/7899/commits/db1b619ef2464c32f3af87b160077894376903c8

> > Yes, that's correct, there'll only be first 50 runs resulting in test pass. That was done to avoid situations like the one described here [crytic/echidna#1231](https://github.com/crytic/echidna/issues/1231) where changes in...