Graeme Morgan comments

Results 34 comments of


                                            Graeme Morgan

Confusing message from AlreadyChecked

Thanks, this is really useful feedback. I agree the finding description should be improved: it'd be great if we could work out an appropriate about of context to say "this...

error: An unhandled exception was thrown by the Error Prone static analysis plugin.

Duplicate of #1250

Add UUID check to AlwaysThrows?

I like that!

IllegalArgumentException when checks UnusedVariable rule

Could you provide some minimal repro?

Introduce @ReferenceEqualitySafe class annotation to avoid triggering ReferenceEquality check

Internally at least, we tend to prefer using `equals` even for cases where reference equality is safe, because `equals` is more self-evidently correct. Is there a reason to actively prefer...

Introduce @ReferenceEqualitySafe class annotation to avoid triggering ReferenceEquality check

I think it's totally reasonable to introduce custom-made classes with exactly 1 instance per value, but is there a strong reason to prefer `==` over `equals` (be that `a.equals(b)` or...

java.lang.IndexOutOfBoundsException BugPattern: UnusedVariable

Duplicate of #3007

`@Immutable` does not recognize safe array handling

Another way to phrase that: the check doesn't do any kind of flow analysis to check whether mutable innards are used in a way which leads to outward immutability. If...

ASTHelpersSuggestions replacement is missing the class name `ASTHelpers`

The canonical fix suggested by a check is the one that rickie@ is referring to, generated via a `Fix` interface. We surface that internally in tooling at review time at...

BugPattern: UnusedVariable

Do you have a small reproducible example?