Graeme Christie

Results 11 comments of Graeme Christie

In the case where a 404 was a known response type, I would not expect an exception to be thrown. The response was an expected condition where a resource has...

@Rsuter do you have any more thoughts on the above ? If you agree in prinicipal that NSwag should support multiple successful response types I can submit a PR for...

While awaiting the offical fix, I have found that creating my own EnableQuery attribute and overriding ApplyQuery to do nothing works. ``` // OData framework's EnableQuery attribute will apply query's...

> Thanks for bring this up @graemechristie. I left some comments on filter to have precise approach. Sorry, I might be being naive, but where are the comments ? I...

> @graemechristie if it is still not visible to you. below my comments > > ``` > Not only `hidden-link`, there may be chances to have more hidden tags which...

> @graemechristie One more small comment on the changeset. Applied the fix as suggested @deepan10 . Sorry - I probably should have picked up on that. Appreciate the catch.

> @graemechristie Nice all good 🚀 sorry again, one more small nit, and need a rebase too! Ive added that change - I might be blind but I can't see...

> Great 🚀 since there are too many commits behind so to have cleaner history suggested rebase. All looks good.. Thanks. > > @freben @tudi2d can you have a look....

Does not seem to be alot of activity in this repo. @SuperQ could you have a look at this PR ?

@simonpasquier are you able to look this PR ?