Grace Goheen comments

Results 72 comments of


Grace Goheen

handle mising objects for strings

Does this address Benoit's point about the `union_relations` macro? I'm not seeing the `column_override` being used

fact model for sources without tests

Isn't our recommendation typically to add tests at the staging level, since this is the "most optimal version of our raw data"? Could be interesting to create a `fact` that...

Table name `fct_multiple_sources_joined` could be misleading as it includes unioned sources as well

I agree the name of this model is confusing. I could be wrong... but I think union-ing directly from the source would still be bad, and this is where we...

Table name `fct_multiple_sources_joined` could be misleading as it includes unioned sources as well

Do we still want to rename this model?

exclusion criteria investigation

A related question came up when the internal analytics team was testing this out, "will documentation coverage also catch models from packages that aren't documented?"

Move arrays macros for Databricks/Spark from this repo to `spark_utils`

Related to #153

Move arrays macros for Databricks/Spark from this repo to `spark_utils`

Got the ball rolling for array macros (will do a separate PR for listagg) - https://github.com/dbt-labs/spark-utils/pull/26

Determine materialization strategy based on # of children / parent nodes

Related to https://github.com/dbt-labs/dbt-project-evaluator/pull/160

I'm going to create a safe_divide cross db macro in dbt_utils - eventually, we can use that for this calculation instead!

PR has been created for dbt-utils - https://github.com/dbt-labs/dbt-utils/pull/697

Add model version to test output

@epapineau relevant to our convo!