Guillaume Racicot

Results 66 comments of Guillaume Racicot

Making `kgr::autowire` a drop in replacement for `kgr::dependency` would be really great.

To build a object in place with this mechanism, we need C++17 mandatory copy elision.

The container retains very little information about services. It contains a pointer to a service definition and optionally, a pointer to a function returning the contained instance. We could traverse...

@pixelbrahma you pushed glfw binaries for windows in your pull request. If it was really your intention to pushed those binaries, know that this is not how glfw ships binaries,...

I think KDE, Windows and MacOS also has the concept of dark vs light themes.

@JonLiu1993 Hi I noticed you added the `requires:author-response` label, but I'm unsure what response you need.

> @gracicot, The above are all my review comments, please take a look. @JonLiu1993 Sorry for pinging again, but have you submitted the review? I'm not seeing any review comments,...

It should be all good now!

I just tested it and everything works as expected!