vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

[kangaru ] Update to version 4.3.1

Open gracicot opened this issue 2 years ago • 5 comments

Describe the pull request

This pull request updates kangaru to version 4.3.1

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

gracicot avatar Sep 16 '22 20:09 gracicot

Unknown CMake command "vcpkg_cmake_configure".

Maybe the installed vcpkg-cmake (for the host triplet) needs an upgrade. Check with ./vcpkg upgrade.

dg0yt avatar Sep 17 '22 03:09 dg0yt

@JonLiu1993 Hi I noticed you added the requires:author-response label, but I'm unsure what response you need.

gracicot avatar Sep 19 '22 15:09 gracicot

@JonLiu1993 Hi I noticed you added the requires:author-response label, but I'm unsure what response you need.

@gracicot, The above are all my review comments, please take a look.

JonLiu1993 avatar Sep 20 '22 01:09 JonLiu1993

@gracicot, The above are all my review comments, please take a look.

@JonLiu1993 Sorry for pinging again, but have you submitted the review? I'm not seeing any review comments, not here, not in the files changes tab

gracicot avatar Sep 20 '22 03:09 gracicot

It should be all good now!

gracicot avatar Sep 21 '22 13:09 gracicot

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

JonLiu1993 avatar Sep 22 '22 07:09 JonLiu1993