Ruturaj Mohite

Results 46 comments of Ruturaj Mohite

Extremely sorry for a late review. Will review this asap

> I would like to work on this issue... @tachyons @gr455 Yep go ahead!

@aman-singh7 Seems good to you?

I know these aren't a part of the PR but can you look at these, if these can result in XSS, you can just escape them; else ignore https://github.com/CircuitVerse/CircuitVerse/blob/master/simulator/src/circuit.js#L168 https://github.com/CircuitVerse/CircuitVerse/blob/master/simulator/src/circuit.js#L173...

This PR still needs work. A bunch of bugs with this one

How does this fit with our i18n? // @vedant-jain03

@pulkit-30 I believe this issue was fixed in https://github.com/CircuitVerse/CircuitVerse/pull/2356. Can you verify?

> Hey @gr455, I verified this issue with the [mentioned](https://circuitverse.org/users/1935/projects/4774) circuit on the local development... Yes, this issue is still valid > > Screen.Recording.2022-03-02.at.9.58.57.PM.mov > I am redrawing the circuit...

@Dnouv Any updates on using the array for IC numbers?

> @gr455 can we merge this? Let's wait for Aboobacker's review. He is down with covid at the moment, so will take a little while to be back.