CircuitVerse
CircuitVerse copied to clipboard
Touch compatibility || GSoC'21 + GSoC'22
GSoC'22
Fixes #2931 Fixes #2964 Fixes #3058
This PR is for New UI designed For CircuitVerse website Small screen version
Describe the changes you have made in this PR - Following things are changed for smaller screen 1.Circuit Element (Redesigned) 2.Properties panel (Redesigned) 3.Time Diagram (Redesigned)
Following new things are added in this PR for smaller screen 1.Touch button menu 2.Live button (Fit to screen, Undo, Delete) 3.Quick menu 4.NavMenu for the small screen 5.Portrait mode
https://user-images.githubusercontent.com/76155456/179480807-c93e69fc-4984-4465-8ce7-4f2ef4988101.mov
cc: @ZadeAbhishek
Coverage remained the same at 81.907% when pulling 4951bfdd3c12e2f06a54d7c87852907d3b385ef6 on pulkit-30:TouchCompatibility-phase2-ui into 55ddeacf50e5f43f103599869f08abb6059f0d16 on CircuitVerse:master.
@aman-singh7 Seems good to you?
I know these aren't a part of the PR but can you look at these, if these can result in XSS, you can just escape them; else ignore https://github.com/CircuitVerse/CircuitVerse/blob/master/simulator/src/circuit.js#L168 https://github.com/CircuitVerse/CircuitVerse/blob/master/simulator/src/circuit.js#L173 https://github.com/CircuitVerse/CircuitVerse/blob/master/simulator/src/circuit.js#L216
Code Climate has analyzed commit 4951bfdd and detected 41 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 8 |
Duplication | 28 |
Style | 5 |
View more on Code Climate.
@pulkit-30 Looks real good! Just noticed that when you pinch to zoom, the centre of the zoom is not between my pinch. But these changes look real good. Amazing 🎉
I will fix them 🎉 Thanks 🚀
I want to work on this project! Resume.pdf