Gregor Martynus
Gregor Martynus
A good place to start is to discuss a "dream API". Gather your use cases and make up the best possible APIs to make them possible. Then we have something...
This looks great! How would like to define mocks beyond just headers?
Thanks for opening the issue! I’m not sure how redirects are currently handled / why 302 are currently not recorded, we would need to investigate. Did you find out anything?...
Yes, I agree that nock should correctly record redirects as two requests/responses. > About the 302 in general, this part : https://github.com/nock/nock/blob/beta/tests/test_recorder.js#L129 , seems to work, so I suppose this...
Next step is to start a pull request with a failing test
Tests look good, thank you! Did you experiment with fixing it and see if it breaks any other tests?
@att14 could you start a pull request with a test replicating the issue? That'd be a great start to address it
I thought there was a way to access the raw request body but cannot recall it right now. Can you check the tests if there is one doing that? That's...
> where you dont know beforehand what the body will be Just curious: how come you don't know the body? I'd expect a test to run in a fully controlled...
I am refactoring the intercept logic right now, you can follow my progress at https://github.com/nock/nock/discussions/2247, the current code is at https://github.com/nock/nock/tree/code-review/modules/intercept-node-http. I had to expose an extra method which does...