Gregor Martynus

Results 1369 comments of Gregor Martynus

You can implement max pages using the iterator https://github.com/octokit/plugin-paginate-graphql.js?tab=readme-ov-file#octokitgraphqlpaginateiterator, would that be an option? Using iterators is recommended anyway, as it's much more memory efficient.

I'm reluctant to add this new API because it diverges from what we have in the REST API pagination method: https://github.com/octokit/plugin-paginate-rest.js?tab=readme-ov-file#octokitpaginate It's fairly simple to add this API. But once...

All yours :) There are `@ts-ignore` statements left in `wrap-request.ts` and `error-request.ts`

did you try setting `retry` on the specific request? We have this documented in our docs

> So does that mean even if I get a 200 response that the plugin will continue to retry up until the max retries? no, only in case of error...

I don't think so, not at this point. Now I understand your request for the `doRetry` parameter, sorry it took me so long. Yes, I agree, a `doRetry` parameter might...

@hiimbex do you have CI setup yet? Note that the tests pass although I didn’t implement the handling of the `pull_request.synchronize` action yet. This is confusing me, it looks like...

For the record the "fix" is simple ```diff - app.on('pull_request.opened', async context => { + app.on([ + 'pull_request.opened', + 'pull_request.synchronize' + ], async context => { ``` I just don’t...

I'll try to reproduce the problem. For the time being, given that you are building a request handler, you might be interested in https://github.com/octokit/app.js or https://github.com/octokit/oauth-app.js (if you are only...