Gregor Martynus

Results 1369 comments of Gregor Martynus

> I’m fine with removing node 12 from the matrix. I guess `esbuild` is more suitable for front-end bundling if old browsers should be supported since `@pika/plugin-standard-pkg` always compiles to...

@baoshan hey I'm interested in moving this forward :) What's the latest status with your port? We are in the process of removing the pika build tools and replacing them...

Sounds good, I'll see if I can find the time this weekend to merge your changes and adapt them to the @octokit conventions > Jest (which is heavy IMHO) yeah...

I'm confused about the linting error, I cannot reproduce it locally šŸ¤·šŸ¼ I do however see the `test/standalone.test.ts` test failing?

Looks like a Deno error to me, I cannot reproduce it with Node. Tested with Node v18.8.0 and v16.17.0. Unfortunately the libraries are not native ESM yet, Deno is using...

why not both? Maybe start a PR with Deno tests, without removing the existing tests, and we take it from there?

Hmm not out of hand, I'd have to investigate myself. I have not seen this happening before

Another error can look like this ``` GraphqlResponseError: Request failed due to following response errors: - Could not resolve to a node with the global id of 'PVTI_lADNJr_OAAWBdc4Cg8PL'. ```

> * [ ] Create an API route that does Octoherd related functions based on the custom script (may need @gr2m's advice on how to perform npx/ Octoherd commands in...

> Do you mean creating the OctokitJS instance at the frontend browser is safer than how I'm creating the OctokitJS instance at the API route I wouldn't say it's safer...