Gabriel Pordeus Santos
Gabriel Pordeus Santos
I ran this on my local lab and it seems to be working fine, with proper DEBUG and TRACE split. If there's anything to point out, I'd say that maybe...
> @gpordeus , this sounds like a good use case for an integration test. Will you consider that? Sure, on it.
@DaanHoogland I've added the integration test.
@DaanHoogland Thanks for the review. > CLGTM, but don't you think the replacement code should be called inside the `VirtualMachine.add()` methods, @gpordeus ? Do you mean the original methods (`VM.addToVCPUsParams()`,...
> @gpordeus Unit tests are failing during build. Can you check & fix those? @DaanHoogland @vishesh92 It seems the test failed because dl.openvm.eu was down at the time. Could you...
> @gpordeus the test run with these env specs fails a bit, is that expected? what did you use? I tested it manually on a local ubuntu lab with xcp-ng-8.2...
> Can you add unit tests for the new method added? @RodrigoDLopez Added them, what do you think?