Gabriel Guilbert

Results 21 comments of Gabriel Guilbert

Same here, I'm supprise such an old and obvious bug ia still there in the latest F-Droid package.

@namhyung That's a good idea, I'll try to add some basic target in the current Makefile. @honggyukim Building the arch stuff in a separate lib should not longer be needed....

Rebased the branch and removed the intermediate `libmcount_entry` static library. @honggyukim Turns out your build error was caused by `-fvisibility=hidden` not used. I believe that Arch Linux has this option...

* Rebased on `master`. * Optionally build `dbginfo` and `demangler` binary with `-Dbuild-dbginfo=enabled` and `-Dbuild-demangler=enabled` * Don't build tests by default. If `ninja check-unit` or `ninja check-uftrace` is ran, a...

Alright, did some modifications again, hopefully, I didn't broke anything, I'll be testing more the upcoming weeks. Mainly, * You are right, I remove `with-tests`, `build-dbginfo` and `build-demangler`. They are...

I fixed it, commit 31d89ea added a new argument to `version.sh` and the generation failed. When I rebased against `master`. It kept the old one and my build wouldn't failed....

* Applied your patch. * Renamed `ninja tests` to `ninja unittest`, `ninja uftrace-tests` to `ninja runtest`. * Cannot use `ninja test` for running both since it is a reserved keyword....

Sorry, I forgot some points. > In addition, -Dwith-libelf=disabled has to disable with-libdw as well. So the following cannot be compiled. Fixed it. > I found one more. The libmcount*.so...

> Could you add meson -Dcc=clang or meson -Dcompiler=clang so that we can select the compiler to gcc or clang? Turns out that it can be done using `CC=clang meson...

I've pushed the changes in separate commit if you want to see exactly the change I made. When it is ready, I'll squash all of them into one.