gpetters94

Results 60 comments of gpetters94

I've looked further into the problem and it seems that upgrading sdl2 to 2.0.5 is what broke it. Downgrading to 2.0.4 fixes the problem.

@maxigaz Downgrading SDL2 doesn't work for me anymore. It did for a while, but now nothing does.

@maxigaz Doesn't seem to work for Dark Souls, which was what I was using this for.

> @gpetters94 i fired the tests but they're gonna fail (though I'm not sure which ones) because you haven't genereated the cpp definitions like here https://github.com/pytorch/pytorch/pull/79194/files. you need to run...

Sorry for all the small commits, still not used to locally testing PyTorch code.

> > Sorry for all the small commits, still not used to locally testing PyTorch code. > > np but you're gonna have to squash before it can be merged...

@makslevental Okay, it's rebased to TOM and squashed, so it should be good to go.

@eellison Some of the tests are failing, but it doesn't look like the errors are due to my code. Do you think this can be merged as it is now,...

> Could you add a assert_jit_shape_analysis=True in the relevant place like is done in the following diff so that we can test this function: [6b6c63c](https://github.com/pytorch/pytorch/commit/6b6c63ce5e0b54eb92cdd88f3bb87efc7adeaf9c) > > Also I recommend...

> The tests are erroring out due to an incorrect shape compute mapping function schema name. I applied the changes and am rerunning tests. Ah, I see. Thanks for the...