Giampaolo Bellavite

Results 175 comments of Giampaolo Bellavite

thanks @matheusmb for your detailed report ! you are right the controlled vs uncontrolled state isn't the ideal here. The code should read something like: ```tsx const handleSelect = (value:...

Hey this is more difficult than I thought. Please have patience...

@matheusmb to help - could you create a (failing) test case, reproducing the issue? 🙏🏽

Interesting issue. Thanks for the report and for being open to discuss it before starting the hard work :) > It's iterating per day within the selected date range, which...

> If I understood correctly, we must consider the whole selected date range in the logic, but I'm confident we can optimize it, I'll work later when I have time...

@karlshea yes I've patched your PR with some more changes. > Oh I see you fixed the import. So I guess it could go either way, the change I just...

> Thanks for taking a look! Also would like to say thanks for the package, I spent the last several days moving a big project from moment/react-datetime to date-fns/react-day-picker and...

(will publish the fix later in the day...)

> > Good find! Which version of TypeScript are you using? > > Im using v4.3.2, this is where i found this issue, and then i updated to the v5.6.2...