Giampaolo Bellavite

Results 175 comments of Giampaolo Bellavite

@ongyuxing I see it now – thanks for the clear explanation! So yes, feel free to add the `type-fest` dependency. This is a great change, looking forward to release it...

Thanks @ongyuxing . I'm seeing interesting types errors... I am looking at them.

Sorry for hi-jacking your PR, I couldn't get actions working on your fork... I added a test and removed the need of type-fest in [`6571670` (#1718)](https://github.com/gpbl/react-day-picker/pull/1718/commits/6571670bc8e4e373d4a91074f613a680b64e65bb). Could we start from...

> @gpbl The argument for `onSelect` is currently being inferred as `any` type. You need to add "strict: true" to the "compilerOptions" in the tsconfig.json for website. Then TypeScript will...

OK I want to give it a second try :) I'm investigating these errors in the test: https://github.com/gpbl/react-day-picker/actions/runs/4387214125/jobs/7824904268#step:6:20

If I make the `onSelect` optional, without strict mode the only thing that is failing is: ```tsx export default function Example(props: DayPickerProps) { return ; } ``` I don't think...

@samuelg0rd0n we plan to implement this in the next mayor version (still WIP), as it may be a breaking change.

Please checkout this [proposal for generic types in `DayPickerProps`](https://www.typescriptlang.org/play?exactOptionalPropertyTypes=false&noImplicitOverride=false#code/PQKgBApgzgNglgOwC4FoAmcoEMBGMJgID2KAxkQlEfmCMAFBwC2ADkQE5JgBKEWpXAGbsiTMACJ2fAeIDc9Rqw5cA3mAAiWJBG5YEAcwgAaMAEEBcAG4QAskQyC4EdlDABfMMNESp-VGiwATxQWOFIAa2c5BQgADzZOMCRAlgJNQIBlCHwLCjs0AgBeCShEfXxxMAAfCSYAVxgkOBYK6p89Q2j6OISuZNSNIIAFMMj2LJztNAA1LBg6iAAeABV8gjjtBDRXdImIXIQ1gD4wYoBtejAwVfsIegBdSFjN7bAz8VKDCvvLsAB+QbaNp1LYQRwICBoX4ALjeNwKjw2EC2rne9UazW+vwBpnY7CCi002hONRBBXBkJhgJ0HQIpNBFLQ8m68WUSRSaSCewEAFFrMgABJ6ND4dgrNZPF47LnZfZNPK3E7FAAUvwCgSgsPSIwizm5U1m8yW8IgRyMvygsoEkPSWq0xl+fistnscEczk1Zgs1nybqcLnNVwgsN4fgAdHY6pa+cikPQAJSnE6WIhwJmMZDOQT8TmBHVjDJlfBDEQsVxIlGDPOjZwAISwlpLRDLYBUvyYt1hHyLEEq9PJiEh8iulsmkL+duruvGVoNcwWi27X17JLAZLBg-TVwo+onVf1McFwtFi8+5RXw7AUgAjnU4FI0HucERqHwEPI3BntOxs6Rc-nnBsBomibFsK1ebUa3YetG1LVw2yuDsCi7dEmhaXtL1HOVx0nACZzHGZ5yWcRUMxFdgQZTdLx3Wc912WdDyQIUthPEjgLI8QjkvJhED3BA6iYHBnG4rBYj4gShPYD8vyzHMqzw3QDAgUDy2eZEIOGKCYOUuDW3bTt2iU6IR1nHD5Kg-VIUNBdJFpTiKIHCEtzAGjJjomVJkY5iRWcRd8SMrj2142F+ME4T21E8Swqk+hPxkn85Mg6dtJUvSrlIGAGygAA5LAmAgPcoCQdgymk+h+n-KCVPFW5JXU6VMlnOAFQKJU0rAJCCthE0HI3JyPzAAAyMBlTOE1ETUysznXRkfiuAEkrGFK4KpMa1gmqU3iXc9xDm-5zOnQtlxU1bxrqqa2IxdDduxA6xiAjETquWE1tuDb6q2-zOj2hbNOnRTDCesBcK0hsdObKB42ZQQQQOO7fJ68CGv1ZrDkVVUrhYOCQenaqTSOBN2qkJA6nYBAwEWLHTRUAApDIAHlsrDIqSoMN1AmVLGIZMfiYBgEwACZ4zcRZgCpwK4phhA4eWaAkAAYVENgIWQZVEwQq8IBJsmRt+K5FgJq4jdbUAwAyAALIgGjQMAWCy9lUlIc39nCWhgE-Y39cW5wwGAQ3PcJP6xg625Cm21o-b1o3A6nMYo+Nzqw7PCp46Nm87wfVOTIIwoVAhAB3ak1Y9z3twQfVc+VdVE0KE5yEoV8wxgIh9CroJhdTyPS5jvCs5Dgow9I66+54hBc4ARhL0umFE3OAFYp89rDrTQXOzgLov4x5iBC6JCA1fuRfjdcuVK-VSGkzAc+-jDGeWGVNvAhruuKCofAm5bx-4w70uu4D732Aj1DrZIyI9EATyPkbGesR56QOzthVeKg1BeCYCFHem8TBICIGg3e9o1buDgS5cus4z5BAvrXK+ZCb4oMgX-Y2KhTYWytjAG22V6bLFtvbCqTsXZu0gT3KCmtbz3khL7I4KhKjiEgQw8AAADdOIi0CyLAKQPQYAhJrktDbCgMBAhgHzs7cmicADkycIDGLDHw1OAjpxCIzpCXOM1NweDodHABdjFG52zDAS0Lj-bGxscHE+AhSFP0vuqPxEiJDSNNrI4JSBlGqPJhoqMoidF6IMciMAWB+4EEwGAKAjs-SQjDMYqx3d3HQIgWIqJUjU4yLALI6BiS1EpK0UQ3R+jDG5MKMYoe+AqhfXMZYug-DKmhxUE4pyHgFEPhqZImJ4AhhZTKNk8msipmQmUZ1Apltrb6I4K7BshAiC5JGe7ax4yB6TMotMohFcVBf3CUEPxlyg4+0TuHXsHVZ4qEnvM6J9TYnNJUa0ggqTtEIE6Zkoxoc+nsXQhY8p-93nsB6ZdNCrRZkOJuY5SEkSFlArkdipRoLkngvaekrpWSTFmKRaMt5scPnAKGZUElAK6mlwafIiAwiHwtPJZotJUKMndNpT2elFyKmovRaygpplEEbz3sXDlizGkkoFeoilwroVirhXS85i9Rb+yhrFGIrJEjkiwMBa4ctFZKBVkgeQQA). Any feedback?

Hey thanks a lot for your contribution. Before changing the role, I'd like to add more accessibility tests - so please have patience before we merge this. BTW, do you...

OK @Kosai106 I could add the aXe tests for website. Now that the role is `button`, I need to fix the other test failures :)