goulvenb

Results 9 comments of goulvenb

Hey, I just made a similar PR yesterday : https://github.com/microsoft/markitdown/pull/1184 I have a question about some choices you made on your workflow ; normally i work with Gitlab and not...

I just answered in [#1184](https://github.com/microsoft/markitdown/pull/1184) I believe it would be better to communicate either here of in [#1184](https://github.com/microsoft/markitdown/pull/1184), so i commented first on my PR, but in case you want...

No worries @seuros ! And also, thanks for your answers to my questions ! As you added me to your repo, and as i'm still relatively new to collaboration using...

I forgot to ask : > but your PR will need to have just 2 commits. Why 2 commits ? I'm asking more in the way of "why would afourney...

Thank you for your insight ! As i said, i'm pretty new to collaboration using git so any intake is welcome 😊 I'm gonna search a few terms, like squashing...

Well, I think @seuros did not see my message... However, as everything is up to date and as no uncommitted changes were made in a week (in our repo), i...

@microsoft-github-policy-service agree

Forgot to say, there's a need to create a project variable called `REGISTRY` that contain, for example, "ghcr.io" (or "docker.io" but then there'll be a need to retouch my commits)

Hey @afourney, As i just said in [#1186](https://github.com/microsoft/markitdown/pull/1186) : > it was the first workflow i made, i henceforth don't have much knowledge about them However, i would love to...